Repository navigation
Use the shared verify-lockfile workflow - #20
Conversation
Test Results 8 files ±0 8 suites ±0 5m 5s ⏱️ +21s For more details on these errors, see this check. Results for commit 817791f. ± Comparison against base commit 527cea2. |
|
@pullfrog please rebase and review. Are the failing tests caused by my changes? If not, then please create issues to fix them. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
The change itself looks good, and the failing checks are not caused by it. But the branch now conflicts with main in actions.lock and needs a rebase before it can merge. I couldn't push one from this review run (pushes are blocked in review mode), so the exact resolution is below.
Reviewed changes
I reviewed the switch from the copied verify job to the shared reusable workflow, plus the relocked actions.lock.
- Shared verify job:
verify-lockfile.ymlnow callsrestatedev/restate/.github/workflows/verify-lockfile.yml@main. Triggers and the caller'spermissions: contents: readstay the same, andverify / verifypasses on this PR. - Relock: the
verify-lockfile.ymlentry no longer lists any actions, and the now-unusedactions/checkout@v7.0.1dependency is dropped.
⚠️ actions.lock conflicts with main after 6a63deb
6a63deb (add Pullfrog workflow) added .github/workflows/pullfrog.yml, which uses actions/checkout@v6.1.0. It also added a actions/checkout@v6.1.0 dependency right next to the v7.0.1 entry this PR removes, so the rebase conflicts. I resolved it locally: I kept v6.1.0 and dropped v7.0.1. After that, gh actions-lock --verify (v0.4.0) reports All 6 workflows valid.
Technical details
# Rebase shared-verify-lockfile onto main
## Affected sites
- .github/workflows/actions.lock — `dependencies:` block, conflict between `actions/checkout@v6.1.0` (added on main) and the removed `actions/checkout@v7.0.1`
## Required outcome
- After `git rebase origin/main`, the `dependencies:` section must contain `actions/checkout@v4.4.0` and `actions/checkout@v6.1.0`, but not `actions/checkout@v7.0.1`:
```yaml
'actions/checkout@v6.1.0':
ref: 'v6.1.0'
commit: 'sha1-d23441a48e516b6c34aea4fa41551a30e30af803'
owner_id: 44036562
repo_id: 197814629
```
- Keep the `'.github/workflows/pullfrog.yml':` workflow entry from main and `'.github/workflows/verify-lockfile.yml': []` from this PR.
- Running `gh actions-lock --verify` should print `All 6 workflows valid`. Running `gh actions-lock` to relock after the rebase gives the same result.ℹ️ The failing checks are a test-harness flake, not caused by this PR
Features integration test and Test Results report the same single failure. All 321 / 321 tests passed, but one test class (ServiceToServiceScopeConcurrency) failed to initialize: exposeHostPort in the sdk-test-suite harness hit a TimeoutException while forwarding a host port to the Restate container. This PR doesn't touch integration.yaml or any SDK code. The integration runs right after it passed (#19 at 2649807 and main at 6a63deb), and so did every recent scheduled run on main. I filed #21 to track the flake. Re-running the job should be enough to get it green.
claude-opus-5-5 ｜ 𝕏
|
@pullfrog rebase and resolve conflicts. |
|
Rebased Conflict in
|
Call the reusable workflow instead of keeping a copy of the job, so the gh-actions-lock version is maintained in one place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # .github/workflows/actions.lock
817791f to
17ad39e
Compare
Summary
Replaces the copied job in
verify-lockfile.ymlwith a call to the shared workflow inrestatedev/restate(restatedev/restate#5721):The
gh-actions-lockversion is then maintained in one place for all restatedev repositories. Dependabot can't bump it because it is a CLI argument (gh extension install github/gh-actions-lock --pin v0.4.0), not auses:reference. The workflow name and triggers stay as they are.actions.lockis relocked: theverify-lockfile.ymlentry no longer listsactions/checkout, which is now covered by restatedev/restate's own lockfile.verify / verifyinstead ofverify. No branch protection or ruleset in this repository requires the old name.Test plan
gh actions-lockrelock: all workflows validverify / verifypasses on this PR (the shared workflow already passes in the 10 Wave 1 repositories, e.g. Add GitHub Actions workflow lockfile e2e#462)🤖 Generated with Claude Code